Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Reportback ie bug#3964

Merged
sbsmith86 merged 3 commits intoDoSomethingArchive:devfrom
sbsmith86:reportback-ie-bug
Feb 12, 2015
Merged

Reportback ie bug#3964
sbsmith86 merged 3 commits intoDoSomethingArchive:devfrom
sbsmith86:reportback-ie-bug

Conversation

@sbsmith86
Copy link
Contributor

This is really ugly and not and ideal solution. We are using browser sniffing to detect if we are on ios safari, which is the only browser that takes into account EXIF data.

  • If we are on IOS then, it reads the file as an ArrayBuffer and does all the EXIF stripping.
  • If we are not, then it reads it as a dataurl and continues normally.

This will need a major refactor as it is repeating a lot of code.

@DoSomething/front-end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch!

@DFurnes
Copy link
Contributor

DFurnes commented Feb 12, 2015

Seems like a good temporary fix to me!

sbsmith86 added a commit that referenced this pull request Feb 12, 2015
@sbsmith86 sbsmith86 merged commit 1b82511 into DoSomethingArchive:dev Feb 12, 2015
@sbsmith86 sbsmith86 deleted the reportback-ie-bug branch March 6, 2015 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants