Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Reportback error display#4003

Merged
sbsmith86 merged 2 commits intoDoSomethingArchive:devfrom
sbsmith86:reportback-error-display
Feb 17, 2015
Merged

Reportback error display#4003
sbsmith86 merged 2 commits intoDoSomethingArchive:devfrom
sbsmith86:reportback-error-display

Conversation

@sbsmith86
Copy link
Contributor

Fixes #3969

  • DRY'ed up the image loading logic by moving it to it's own function
  • Moved the error message to the top of the reportback submissions form.

@DoSomething/front-end

@DFurnes
Copy link
Contributor

DFurnes commented Feb 17, 2015

Looks great! :shipit:

sbsmith86 added a commit that referenced this pull request Feb 17, 2015
@sbsmith86 sbsmith86 merged commit 2c40e3f into DoSomethingArchive:dev Feb 17, 2015
@sbsmith86 sbsmith86 deleted the reportback-error-display branch March 6, 2015 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

let's move "image too small" error message at the top of the form, not the bottom

2 participants