This repository was archived by the owner on Oct 29, 2020. It is now read-only.
We care what you said#4109
Merged
angaither merged 4 commits intoDoSomethingArchive:devfrom Mar 4, 2015
Merged
Conversation
Contributor
angaither
commented
Mar 4, 2015
angaither
commented
- adds the file caption to the reportback permalink page.
- remove default vars from theme array, because 💁
This is for sanity.
Contributor
There was a problem hiding this comment.
Potentially use reportback_file_load ? https://github.com/DoSomething/dosomething/blob/v0.4.21/lib/modules/dosomething/dosomething_reportback/dosomething_reportback.module#L394
Contributor
|
Code looks good, but would be nice to use the existing |
Contributor
Author
|
@aaronschachter updated |
Contributor
There was a problem hiding this comment.
Don't need a space (I had accidentally added a space in my comment)
Contributor
|
Just fix stray space and ready to ship 👍 |
Contributor
There was a problem hiding this comment.
Totally minor, but maybe $is_owner makes this a little more readable (current could potentially mean the latest Reportback File submitted for the Reportback)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.