Permalink as pitch page

[angaither]

This turns the do it button on a permalink page into the Sign Up button
Currently, this only supports Authenticated Users (and shouldn't be merged just yet)

This also includes some light refactoring and of course, ever present 👾 fixes

Fixes #4154
Fixes #4190
Fixes #4115

@aaronschachter I created #4197 for the anon users, but it doesn't seem like that get_signup_button is the way to go for that. do you have any feels on how to handle that?

[aaronschachter]

Seems ok. What is the issue in using get_signup_button to display the login/reg form for anon users, @angaither ?

[angaither]

@aaronschachter the thing I've been stuck on is getting the redirect after logging in to work.
I added this line to do the redirect, but the user module redirect after logging in overrides the redirect that I set in this hook.

[aaronschachter]

@angaither Does it work to change the User module's redirect to only execute based on whether or not they were on a Campaign page or a Reportback ?

[angaither]

@aaronschachter no, for some reason dosomething_reportback_signup_submit isn't getting executed at all on a registration/sign in. it's only getting called when the user is already logged in.
I've tried scoping the redirected to not run on reportbacks, and even commenting it out entirely (when I do that it redriects to /user)

[angaither]

ahhhhhHA,
so I think the custom handler is getting added to only the top login/register form
if I click the login button on the top of the page, the redirect work, but the actual signup button that pulls up the modal doesn't work.
the modal login forms must be handled differently...

[angaither]

ok, now this works cc @aaronschachter

[aaronschachter]

Looks good! 👍