This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Anchor card cta at bottom of the card#4233
Merged
sbsmith86 merged 1 commit intoDoSomethingArchive:devfrom Mar 18, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
Is the border-collapse necessary? I thought you really only need this if actually using a <table> in the markup?
Contributor
Author
There was a problem hiding this comment.
@weerd yea, we need it. Without it, the border around the cta doesn't show when it gets set to display: table-footer-group
Contributor
|
👍 |
sbsmith86
added a commit
that referenced
this pull request
Mar 18, 2015
Anchor card cta at bottom of the card
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4194
Made the height of the wrapper of the card column with the text & cta to be 100%. This way, when the cta moves to the bottom of the column on tablet, it will always be at the very bottom of the card no matter how much text is in the copy element above it.
@DoSomething/front-end