Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Permalink show more#4253

Merged
sbsmith86 merged 4 commits intoDoSomethingArchive:devfrom
sbsmith86:permalink-show-more
Mar 19, 2015
Merged

Permalink show more#4253
sbsmith86 merged 4 commits intoDoSomethingArchive:devfrom
sbsmith86:permalink-show-more

Conversation

@sbsmith86
Copy link
Contributor

Fixes #4235

@mikefantini did some research and we tend to get very long answers to "Why I participated." We are going to display the first 250 characters and then provide a button to show the whole answer. This is what this pull request does.

I also moved the script that creates the share popup into the utilities folder.

b9db125c623

@angaither @DoSomething/front-end

@barryclark
Copy link
Contributor

😄 Yessss. I like that @blisteringherb got in there too!

@DFurnes
Copy link
Contributor

DFurnes commented Mar 19, 2015

This is the best pull request I've ever seen. New PR template. 🏆

@DFurnes
Copy link
Contributor

DFurnes commented Mar 19, 2015

Also 👍 to the code, looks great!

sbsmith86 added a commit that referenced this pull request Mar 19, 2015
@sbsmith86 sbsmith86 merged commit 73af6fe into DoSomethingArchive:dev Mar 19, 2015
@sbsmith86 sbsmith86 deleted the permalink-show-more branch July 6, 2015 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

truncate why_participated text on owner permalink

3 participants