This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Header gallery styles#4272
Merged
weerd merged 4 commits intoDoSomethingArchive:devfrom Mar 20, 2015
weerd:header-gallery-styles
Merged
Header gallery styles#4272weerd merged 4 commits intoDoSomethingArchive:devfrom weerd:header-gallery-styles
weerd merged 4 commits intoDoSomethingArchive:devfrom
weerd:header-gallery-styles
Conversation
Contributor
Author
There was a problem hiding this comment.
@aaronschachter I made a quick change here cause returning FALSE apparently is no good if using isset() in template cause it sees it as the variable having a value (which makes sense). So I changed it to return NULL so the conditional in template works correctly.
Contributor
|
Really nice! 🚢 Few teeeny tiny comments, but otherwise all good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4188
Fixes #4186
This should wrap up the styles for the new showcase gallery in the header. Adds some modified patterns which will need to be moved into Neue. Also pulled out the
.photopattern and placed into/patternsdirectory for easier reference when moving to Neue.The rotation with
nth-childaims to rotateoddandevengallery items plus a could extranth-childdefinitions to add some variety in between 💃The
.-hiddenclass is only temporary and will be used for easy Optimizely tests to toggle between showing or not showing the showcase gallery.@DoSomething/front-end