Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Added goal/progress vars to the dosomething_helpers config.#4297

Merged
angaither merged 3 commits intoDoSomethingArchive:devfrom
angaither:add-goal-progress-useless-helpers
Mar 26, 2015
Merged

Added goal/progress vars to the dosomething_helpers config.#4297
angaither merged 3 commits intoDoSomethingArchive:devfrom
angaither:add-goal-progress-useless-helpers

Conversation

@angaither
Copy link
Contributor

The functionality for this isn't finished yet, but it might get added to prod as is.
it just adds new vars to dosomething_helpers in prep for #4281 & #4282

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not required by default. Could you please check it and remove if yes?

@angaither
Copy link
Contributor Author

@sergii-tkachenko updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed t() here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sergiitk
Copy link
Contributor

👍

angaither added a commit that referenced this pull request Mar 26, 2015
…pers

Added goal/progress vars to the dosomething_helpers config.
@angaither angaither merged commit 51b5eeb into DoSomethingArchive:dev Mar 26, 2015
@angaither angaither deleted the add-goal-progress-useless-helpers branch March 26, 2015 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants