This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Add ES5 shim for Internet Explorer 8.#4433
Merged
DFurnes merged 1 commit intoDoSomethingArchive:devfrom Apr 28, 2015
DFurnes:es5-shimmy-shammy
Merged
Add ES5 shim for Internet Explorer 8.#4433DFurnes merged 1 commit intoDoSomethingArchive:devfrom DFurnes:es5-shimmy-shammy
DFurnes merged 1 commit intoDoSomethingArchive:devfrom
DFurnes:es5-shimmy-shammy
Conversation
Contributor
|
Good ole |
Contributor
|
👍 |
DFurnes
added a commit
that referenced
this pull request
Apr 28, 2015
Add ES5 shim for Internet Explorer 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds ES5 shim & sham for Internet Explorer 8 (included in conditional comment). This shims ES5 methods that aren't supported or are bugged in IE8 (like
Object.defineProperty). The "sham" includes workable versions of some methods that are not supported by the engine.This fixes a bug in IE8 that was introduced because Babel assumes a functioning ES5 environment, and seems like a good baseline for curing some browser headaches anyways! (Closes #4430.)
For review: @DoSomething/front-end