Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Promoted reasons#4535

Merged
angaither merged 8 commits intoDoSomethingArchive:devfrom
angaither:promoted-reasons
May 27, 2015
Merged

Promoted reasons#4535
angaither merged 8 commits intoDoSomethingArchive:devfrom
angaither:promoted-reasons

Conversation

@angaither
Copy link
Contributor

Add in promoted reasons checkboxes

Fixes #4496

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergii-tkachenko usually flags these to use ===

@aaronschachter
Copy link
Contributor

Just confirming, so once a Reportback Item is promoted, the whole Reportback is considered promoted? If an editor makes a mistake, will this remove the promoted flag upon changing the Reportback Item status?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this, since it sets Promoted as well as Flagged? Maybe something like setFlags ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I thought about that, but it's not really flags I couldn't come up with a good name for it...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.. hmm. setProperties... setExtras... setFlaggedPromoted ... ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loving setFlaggedPromoted

@angaither
Copy link
Contributor Author

@aaronschachter yeah, it works the same way flagged does, the promoted value will toggle between 0/1

@aaronschachter
Copy link
Contributor

👍

angaither added a commit that referenced this pull request May 27, 2015
@angaither angaither merged commit 6add579 into DoSomethingArchive:dev May 27, 2015
@angaither angaither deleted the promoted-reasons branch May 27, 2015 17:55
@aaronschachter
Copy link
Contributor

@angaither - Random thought around this came to mind. What if a reportback has two items we want to promote, but for different reasons?

Once a reportback item is flagged, the reportback is ignored entirely, so there would never be the opportunity to update the flagged reason upon adding additional litems. With this its different... wouldnt' the last promoted item always overwrite the reason?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Promoted options

2 participants