Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Progress log table#4628

Merged
angaither merged 4 commits intoDoSomethingArchive:devfrom
angaither:progress-log
Jul 6, 2015
Merged

Progress log table#4628
angaither merged 4 commits intoDoSomethingArchive:devfrom
angaither:progress-log

Conversation

@angaither
Copy link
Contributor

Fixes #4605

@angaither angaither changed the title Progress log Progress log table Jun 29, 2015
@angaither angaither assigned sergiitk and unassigned aaronschachter Jul 1, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why both 'id' and 'nid'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it's easier to query search, it looked like need both, when I was testing old records were getting overwritten on each cron

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They you should declare these as an index: https://api.drupal.org/api/drupal/includes!database!schema.inc/group/schemaapi, see indexes
Primary index is nor for search, but for unique identification of each row.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-incremental id is sufficient for this purpose.

@sergiitk
Copy link
Contributor

sergiitk commented Jul 6, 2015

👍

angaither added a commit that referenced this pull request Jul 6, 2015
@angaither angaither merged commit 7351a77 into DoSomethingArchive:dev Jul 6, 2015
@angaither angaither deleted the progress-log branch July 6, 2015 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants