This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Merged
Conversation
Contributor
|
Coooooooool. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors how I was implementing share buttons on the campaign page (problem statement and hot module) and the permalink page.
Adds a function
dosomething_helpers_share_bar()that spits out the markup needed for a standard facebook, twitter, tumblr share buttons, a pattern that we use at least three places on the site. This function also takes care of adding the necessary google analytics tracking classes and UTM parameters to the share links (resolves #4575 and #4611 )@DoSomething/front-end