This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Dr00ps style overrides cleanup#5307
Merged
DFurnes merged 5 commits intoDoSomethingArchive:devfrom Sep 29, 2015
DFurnes:droops-overrides-cleanup
Merged
Dr00ps style overrides cleanup#5307DFurnes merged 5 commits intoDoSomethingArchive:devfrom DFurnes:droops-overrides-cleanup
DFurnes merged 5 commits intoDoSomethingArchive:devfrom
DFurnes:droops-overrides-cleanup
Conversation
This removes the need for another rasterized image, and looks better on retina devices.
Forge styles contents of a field-label inside `<em>` tags like this, so we don’t need another undocumented class for it.
No significant changes here. Just grouping related grossness. :)
This makes it readable by screen readers, which was Drupal’s intent behind this markup. We were perhaps being a bit too zealous before. :)
We had been overriding some nasty CSS included with a Drupal module, but that Drupal CSS seems to no longer be applied.
Contributor
|
cool beans 👍 |
DFurnes
added a commit
that referenced
this pull request
Sep 29, 2015
Dr00ps style overrides cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Just tidying up the overrides stylesheet. 🍃 Nothing terribly exciting going on, but I recommend going commit-by-commit when reviewing since there's a couple of different changes.
For review: @DoSomething/front-end