This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Fixes logout URL#5311
Merged
itsjoekent merged 3 commits intoDoSomethingArchive:globalfrom Sep 29, 2015
itsjoekent:5283
Merged
Conversation
Contributor
There was a problem hiding this comment.
I think we should be using l() here instead of printing out each part of the url.
Contributor
Author
There was a problem hiding this comment.
oh I never heard of that function, looks like what we need
Contributor
|
Yes, |
Contributor
Author
|
@sergii-tkachenko done and done |
Contributor
There was a problem hiding this comment.
Just to make sure, will it generate id="link--logout", as it used to be?
Contributor
Author
There was a problem hiding this comment.
Oh forgot about that one. It doesnt apply any styles, what do we use it for?
Contributor
There was a problem hiding this comment.
It's used as a hook for CasperJS tests.
Contributor
There was a problem hiding this comment.
Contributor
|
Let's bring back the ids and we're good to go 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Fixes the logout URL (on path prefixes it fails)
How should this be manually tested?
Go to any page, including path prefixed ones, and try logging out
Any background context you want to provide?
Issue was the user/logout was being appended to the path prefix, so you'd get a url like ususer/logout. I tried initially just adding a slash to /user/logout, which fixes it on path prefixes. However on other pages this URL breaks. The solution was to just create the URL from scratch and guarantee it's the same URL for everyone, every time on every page.
What are the relevant tickets?
Fixes #5283