This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Merged
Conversation
…egistration mbp call
…ome-naviagtion-items Allowing chrome nav items to be translateable.
If the t() function is nested inside the token_replace() function then it all kinda breaks and the tokens can't be replaced properly. Solution is to separate them out.
…-translate-bug Fix bug with nesting t().
When I switched from testing if the theme settings were falsey (which was failing on ""), I left the "!" in there. I am not a clever man.
Fix missing footer
…r_country Add dosomething_global_convert_language_to_country() lookup to user registration mbp call
These variables are defined, but never used in this scope (dosomething_user_form_alter).
Use Drupal’s `hook_user_login` and `hook_user_insert` to add custom events to the following page load on login/registration.
* After dev is merged back in to global, which will remove the code necessary to make signup email links work, this code needs to be readded.
…-signup-prefix Removing code that adds a prefix to signup email link
Putting these Drupal variables into pot files and having them translate was affecting the replacement of them in code for Droooopal.
This makes more sense, since hook_insert_user seems to be intended more for database-related changes. I've also split message broker logic into a new "private" method for better readability.
…-olé Removing item from pot file that should not be translated.
Removes regional admin access from misc. menu's
…cs-kerfuffle Fix login and registration events
Conflicts: lib/modules/dosomething/dosomething_signup/dosomething_signup.module
Closed
Contributor
|
I think its good to go |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed the merge commits locally, and merged dev into global
@blisteringherb @deadlybutter can you do a spot check that
dosomething_global.modulelooks correct