This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Clean up user login/registration hooks a bit.#5536
Merged
DFurnes merged 1 commit intoDoSomethingArchive:devfrom Oct 19, 2015
DFurnes:user-campaign-signup-hooks
Merged
Clean up user login/registration hooks a bit.#5536DFurnes merged 1 commit intoDoSomethingArchive:devfrom DFurnes:user-campaign-signup-hooks
DFurnes merged 1 commit intoDoSomethingArchive:devfrom
DFurnes:user-campaign-signup-hooks
Conversation
Login AND registration both previously used the `dosomething_user_login_submit` hook, which was confusing at first glance. This shuffles things around to have a shared `authentication` submit handler, and a unique `login` handler for the login form.
Contributor
|
brilliant 👍 |
DFurnes
added a commit
that referenced
this pull request
Oct 19, 2015
Clean up user login/registration hooks a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I was thinking about this after making changes in #5478. Login and registration forms both shared the
dosomething_user_login_submithook, which was confusing at first glance. This shuffles things around to have a sharedauthenticationsubmit handler, and a uniqueloginhandler for the login form.Side effect: we can now cleanly have login-form specific actions, such as a
Authentication - Loginevent that only fires when the user specifically uses the login form. Sweet. 🍬How should this be tested?
I tested to see that expected behavior still works (
dpmevery step of the way~), but would appreciate an extra pair of 👀 just to make sure I didn't do something stupid. 😬For review: @angaither