This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Fix issue with column overflow in Chrome 45.#5545
Merged
DFurnes merged 1 commit intoDoSomethingArchive:devfrom Oct 19, 2015
DFurnes:finder-chrome-column-bugginess
Merged
Fix issue with column overflow in Chrome 45.#5545DFurnes merged 1 commit intoDoSomethingArchive:devfrom DFurnes:finder-chrome-column-bugginess
DFurnes merged 1 commit intoDoSomethingArchive:devfrom
DFurnes:finder-chrome-column-bugginess
Conversation
Contributor
|
looks good to me :) what's the deal? Google no like |
Contributor
Author
|
We had some prior issues with CSS columns in the Chrome 45 that were fixed by switching things from |
Contributor
|
cool! |
DFurnes
added a commit
that referenced
this pull request
Oct 19, 2015
Fix issue with column overflow in Chrome 45.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #5409. Resolves issue with columns overflowing in Chrome 45. (Get it together, Google!)
How should I test this?
Check it out in all sorts of browsers and screen sizes. Tested across a few screen sizes in Chrome 45, Safari 9, Firefox 41 and thing seem to be working well.
Screenshots
Before (in Chrome 45):
After (in Chrome 45):
For review: @DoSomething/front-end