Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Revising a term and updating styles with how it is rendered.#5749

Merged
weerd merged 1 commit intoDoSomethingArchive:devfrom
weerd:missing-translations-05-olé
Nov 9, 2015

Hidden character warning

The head ref may contain hidden characters: "missing-translations-05-ol\u00e9"
Merged

Revising a term and updating styles with how it is rendered.#5749
weerd merged 1 commit intoDoSomethingArchive:devfrom
weerd:missing-translations-05-olé

Conversation

@weerd
Copy link
Contributor

@weerd weerd commented Nov 9, 2015

Refs #5517

What's this PR do?

This PR revises a term in the paraneue_dosomething.pot file and associated term in the t() function wherever it is output. It also adjusts some styles related to how the term is output in the Reportback gallery. There is an issue with include html tags (or even \r\n characters) in a term imported via PO file into Drupal, so the best solution was to remove the extra phrasing (which was planning on being shortened anyway).

Where should the reviewer start?

Take a quick 👀

How should this be manually tested?

Will be tested on Thor.

What are the relevant tickets?

#5517


@angaither

cc: @DFurnes

@DFurnes
Copy link
Contributor

DFurnes commented Nov 9, 2015

A lovely new coat of paint! 🎨

@angaither
Copy link
Contributor

what happened to the 🆒 kids?
👍

@weerd
Copy link
Contributor Author

weerd commented Nov 9, 2015

All the cool kids realized we're all in this together! 🌐

@weerd
Copy link
Contributor Author

weerd commented Nov 9, 2015

#global

weerd added a commit that referenced this pull request Nov 9, 2015
Revising a term and updating styles with how it is rendered.
@weerd weerd merged commit 860b7b8 into DoSomethingArchive:dev Nov 9, 2015
@weerd weerd deleted the missing-translations-05-olé branch November 9, 2015 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants