Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Removes entity usage in static content long text preprocess#5766

Merged
itsjoekent merged 2 commits intoDoSomethingArchive:devfrom
itsjoekent-archive:5574_b
Nov 12, 2015
Merged

Removes entity usage in static content long text preprocess#5766
itsjoekent merged 2 commits intoDoSomethingArchive:devfrom
itsjoekent-archive:5574_b

Conversation

@itsjoekent
Copy link
Contributor

what

Removes entity usage in the static content pre processing for the long text fields.

why does it work?

Cause these entity wrappers are being 💩 lately with global stuff. good ol dosomething helpers extract field data saves the day again!

test it?

All static content should load without error now, regardless if it has intro filled out or not

fixes #5747

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this language thing might cause some wonkyness since we didn't translate static content.
there might not be content in the user's language

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so use the nodes language?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think so

@itsjoekent
Copy link
Contributor Author

@angaither 💥 done!

@angaither
Copy link
Contributor

👍

itsjoekent pushed a commit that referenced this pull request Nov 12, 2015
Removes entity usage in static content long text preprocess
@itsjoekent itsjoekent merged commit 31efce2 into DoSomethingArchive:dev Nov 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

/br/sobre/faqs and /mx/sobre/contacto throw error messages

2 participants