Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Turn off optimizely on build.#5813

Merged
angaither merged 2 commits intodevfrom
sudo-make-me-a-sandwich
Nov 20, 2015
Merged

Turn off optimizely on build.#5813
angaither merged 2 commits intodevfrom
sudo-make-me-a-sandwich

Conversation

@angaither
Copy link
Contributor

Yes, I really do mean it.
Fixes #5811

Yes, I really do mean it.
Fixes #5811
@sergiitk
Copy link
Contributor

@angaither But this code is being executed on pull stage.
Did you intend it to?

@angaither
Copy link
Contributor Author

@sergii-tkachenko yes, just so we can turn off it off locally #1507

@sergiitk
Copy link
Contributor

@angaither Can you also drush pmu (pm-uninstall) it?

@angaither
Copy link
Contributor Author

@sergii-tkachenko sure, but why would we also need to uninstall?

@sergiitk
Copy link
Contributor

@angaither Because that's the correct way to turn modules off.
It will drop its schema and remove its variables. See optimizely_uninstall().

bin/ds Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not "on staging", locally. This is the line that confused me initially, I thought it's intended to be disabled on staging.

@angaither
Copy link
Contributor Author

@sergii-tkachenko I don't think we need to uninstall it, it's just removing tables, all we want is the JS to not be executed locally

bin/ds Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be more consistent to pass -y as the first argument: this is a core-global-option. Not all drush submodules accept global options passed passed as the first argument.

@sergiitk
Copy link
Contributor

👍

angaither added a commit that referenced this pull request Nov 20, 2015
@angaither angaither merged commit 16c23fb into dev Nov 20, 2015
@angaither angaither deleted the sudo-make-me-a-sandwich branch November 20, 2015 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants