Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Update hot module timing logic.#5910

Merged
angaither merged 1 commit intodevfrom
refactor-hot-module-timing
Dec 7, 2015
Merged

Update hot module timing logic.#5910
angaither merged 1 commit intodevfrom
refactor-hot-module-timing

Conversation

@angaither
Copy link
Contributor

Instead of calculating the time a bunch, just set it to vars array on the node.

refs #5907

Instead of calulating the time a bunch, just set it to vars array on the node.
@sbsmith86
Copy link
Contributor

👍 ⌚

angaither added a commit that referenced this pull request Dec 7, 2015
@angaither angaither merged commit 16bde54 into dev Dec 7, 2015
@angaither angaither deleted the refactor-hot-module-timing branch December 7, 2015 21:21
@aaronschachter
Copy link
Contributor

This seems to have broken things on staging:

screen shot 2015-12-07 at 5 05 00 pm

@angaither
Copy link
Contributor Author

hmm @aaronschachter strange that you aren't getting taken to /us

I think it's just an issue with not having translations on staging, but I'll look into this

angaither added a commit that referenced this pull request Dec 8, 2015
This was referenced Dec 8, 2015
@aaronschachter
Copy link
Contributor

FYI - staging.dosomething.org directs me to /us, but staging.beta.dosomething.org does not. Will purge browser history to stop visiting it. We've already made the changes in the LDT iOS app to point to staging.dosomething.org/api

@mikefantini
Copy link

@aaronschachter staging.dosomething.org is behind Fastly whereas staging.beta.dosomething.org is not. This is why staging.dosomething.org directs you to /us but staging.beta does not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants