Makes sure that all node edit links are prefixed #5978
Makes sure that all node edit links are prefixed #5978itsjoekent merged 5 commits intoDoSomethingArchive:devfrom
Conversation
There was a problem hiding this comment.
How dosomething_global_get_current_prefix() can return an empty string?
There was a problem hiding this comment.
Then better use === operand and explain the logic in comment.
Also, !empty($prefix).
There was a problem hiding this comment.
ah, yeah Ill use the empty function
|
@sergii-tkachenko fixed! |
|
I think it's better to use |
|
And explain in the comment after if that the function returns an empty string for Global language. |
|
whats the difference between === ' ' and empty? |
|
Empty = FALSE = '' = 0 = NULL = "0" = 0.0 = array(), etc... |
|
@sergii-tkachenko updated, I think I got what you were suggesting now |
|
Thanks @deadlybutter! 👍 |
Makes sure that all node edit links are prefixed
What's this PR do?
Makes sure that the correct prefix is applied to node edit pages
How should this be manually tested?
Can you click/goto global edit links, and then view the page without error?
What about normal edit links?
Any background context you want to provide?
The node edit logic never cared about prefixes as they aren't required for the correct node edit page. The implications of this however are the cause of #5952
What are the relevant tickets?
Fixes #5952