Adds campaign run nid to signups and reportbacks#6011
Adds campaign run nid to signups and reportbacks#6011itsjoekent merged 4 commits intoDoSomethingArchive:devfrom
Conversation
There was a problem hiding this comment.
It's better to name this $language_code to avoid confusion, as $language is global variable.
|
@sergii-tkachenko fixed! |
There was a problem hiding this comment.
What will happen if the field hasn't been translated to the language?
There was a problem hiding this comment.
oh wait, its the campaign run that gets translated for each, not the field in the campaign? got confused, sorryz
so this should be the nodes source lang, not based on the user lang?
There was a problem hiding this comment.
Hm. Depends on what do you want to achieve here.
There was a problem hiding this comment.
I'm getting the campaigns current NID.
now that I've rethought about it, I think the procedure is this
campaign blah blah
source lang -> campaign run
campaign run
en --> end date, title, etc
global --> etc etc
etc
|
@sergii-tkachenko ok, i think its good now. changed $language_code to just be $campaign->language |
|
Are you sure this behaves as expected? Could you please create a campaign in 2 translations and check if |
|
blocked on this until a decision is made regarding the biz logic |
There was a problem hiding this comment.
You could potentially use this the field extractor function?
dosomething_helpers_extract_field_data($campaign->field_current_run, $campaign->language);
|
@deadlybutter @angaither I pulled down this branch and merged it with the work I'm doing. However, I'm already making a bunch of changes which include the code in this PR. I might recommend closing this one and waiting for the upcoming PR to avoid a slew of merge conflicts? It's not a huge deal if there are conflicts, because we can fix them, but figured I'd mention it :) |
|
@weerd I would rather add this in and change it later. I really want to keep the pull requests as small as possible. What did you change here? I'm also ok with merging this in now if that makes things easier |
|
Had to move the variables around cause they're needed earlier in the function, and a couple other things. Yeah, can we merge this now and I can just rebase the shiz and fix any conflicts :) Just wasn't sure how long we'd need to hold off on this being merged. But if we can merge now that'd be awesome. |
|
@deadlybutter 👍 |
Adds campaign run nid to signups and reportbacks
|
💥 |
4 participants
What's this PR do?
Adds campaign run nid to signups and reportbacks
(Did not touch the API)
How should this be manually tested?
Is the campaign run NID filled out in signups/reportbacks when you do those respective things?
What are the relevant tickets?
Fixes #6008