This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Fixes missing campaign title in reportback mergevars.#6019
Merged
sergiitk merged 3 commits intoDoSomethingArchive:devfrom Jan 12, 2016
Merged
Fixes missing campaign title in reportback mergevars.#6019sergiitk merged 3 commits intoDoSomethingArchive:devfrom
sergiitk merged 3 commits intoDoSomethingArchive:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Will this always be reset by the $node->title_field logic? Is there a case where $node->title_field will not have a value?
Contributor
Author
There was a problem hiding this comment.
This will not be reset if a node isn't loaded for some reason.
Contributor
There was a problem hiding this comment.
With the presence of node_load($entity->nid); above should the "node isn't loaded for some reason" be logged / reported as an error?
Contributor
Author
|
@deezone updated. |
Contributor
|
👍 |
sergiitk
added a commit
that referenced
this pull request
Jan 12, 2016
Fixes missing campaign title in reportback mergevars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
So I think this should fix title in email, sent to a user, which reported back with Mobile App or SMS:
How should this be manually tested?
Any background context you want to provide?
See #5985, #5870.
What are the relevant tickets?
Fixes #5872.