This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Update status on campaign save#6120
Merged
sbsmith86 merged 5 commits intoDoSomethingArchive:devfrom Feb 3, 2016
Merged
Conversation
added 4 commits
February 3, 2016 09:53
…ission. Use `hook_node_submit()` on campaign run submission to update the campaign node. Use `hook_node_validate()` on campaign submission to update the campaign node.
sbsmith86
force-pushed
the
update-status-campaign-save
branch
from
8a8eb9e to
9242477
Compare
Contributor
Author
|
@angaither updated the campaign status function to check for null dates. |
Contributor
|
👍 |
sbsmith86
added a commit
that referenced
this pull request
Feb 3, 2016
Update status on campaign save
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Updates the campaign status when someone changes the campaign run on campaign nodes.
Also, updated the hooks I was using to update the campaign status on campaign run node save to use
hook_node_submitso we can more reliably get the values that had just been submitted by the user.Where should the reviewer start?
Start at
dosomething_campaign.modulewhere I usehook_node_validate()to get the form state of the campaign node that is submitted and allows me to update the value of fields before the form actually gets submitted. This is where we update the status.What are the relevant tickets?
Fixes #6052