This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Adds run nid to view#6172
Merged
itsjoekent merged 4 commits intoDoSomethingArchive:devfrom Feb 18, 2016
Merged
Conversation
Contributor
|
@deadlybutter pics? |
Contributor
|
👍 |
Contributor
Author
Contributor
|
@deadlybutter is that on all reportback views or just the reviewed tab? |
Contributor
Author
|
actually hmm i might have noticed something wrong, let me double check |
Contributor
Author
|
@angaither where else is this view found besides the review tab? |
Contributor
Author
|
yeah this isnt working, i made the above RB (in the screenshot) have a NULL run nid and its still showing up |
Contributor
|
@deadlybutter AFAIK it's only the inbox and reviewed tab, but to avoid issues with form api and the infamous reportback reviewing bug, i think we only want this on the reviewed tab |
Contributor
Author
|
@sergii-tkachenko so @angaither said the dupes are alright, i guess ready for re-review |
Contributor
Author
|
|
Contributor
|
@deadlybutter we probably want run id after |
Contributor
Author
|
okie dokes |
Contributor
Author
|
@angaither done |
Contributor
|
👍 |
This was referenced Feb 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds run nid filter to reportback admin view
How should this be manually tested?
Does it filter out RB's with a diff run nid than specified?
Any background context you want to provide?
Showed Andrea in Slack that signup filtering appears to work already
https://thor.dosomething.org/us/node/6163/signups?uid=&mail=&source=&nid=6166&page=5
What are the relevant tickets?
Fixes #6007