This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Merged
Conversation
Contributor
|
👍 Looks good! Brings to mind whether to kill those Mobile App dates / checkbox fields for housekeeping... |
| $query->join('field_data_field_campaign_type', 't', 't.entity_id = n.nid'); | ||
|
|
||
| // @TODO: this is a temporary fix to address the need to allow unpublished mobile_app campaigns to be retrieved, only for the mobile app. | ||
| if (!$params['mobile_app']) { |
Contributor
There was a problem hiding this comment.
We should update the wiki wiki: https://github.com/DoSomething/phoenix/wiki/api#optional-query-parameters
Contributor
Author
There was a problem hiding this comment.
this doesn't remove the param, it just makes sure all campaigns are published
Contributor
Author
|
@aaronschachter are all mobile app dates/query param unused? |
Contributor
|
Not using them anywhere in iOS. @jonuy? |
angaither
added a commit
that referenced
this pull request
Mar 2, 2016
…-please Professional campaigns only please
Contributor
|
We should be good on the Android side too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
remove unpublished campaigns from the api index.
How should this be manually tested?
do unpublished campaigns show up in the index?
Any background context you want to provide?
This fix was added in with #5175 to support the original
idea in the mobile app, where we had campaigns show up on
the app, but not on the web.
As we are no longer going that route, let's only return
published campaigns.
What are the relevant tickets?
Fixes #6233
doesn't fix