This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Log all the stars#6262
Merged
DFurnes merged 8 commits intoDoSomethingArchive:devfrom Mar 11, 2016
DFurnes:log-all-the-stars
Merged
Log all the stars#6262DFurnes merged 8 commits intoDoSomethingArchive:devfrom DFurnes:log-all-the-stars
DFurnes merged 8 commits intoDoSomethingArchive:devfrom
DFurnes:log-all-the-stars
Conversation
This will log times when we update a user’s Northstar profile… such as when they update their profile on Phoenix or reset their password.
| // Add to request log | ||
| if(variable_get('dosomething_northstar_log')) { | ||
| // Don't log plaintext password. | ||
| $credentials['password'] = '*****'; |
Contributor
Author
There was a problem hiding this comment.
Yeah, we could do that. On the other hand, I wonder if it's worth doing an isset check and only masking the password like this if the field is in the payload... could catch if we're somehow not sending it on every request.
Contributor
Author
|
@angaither Made updates based on your comments. I also added logging to the "register" action. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Hello Drupal, my old friend. This PR adds request logging for Northstar update/verify requests, in the hopes that we can figure out why so many users can't be mock authenticated. 🔍
How should this be manually tested?
If you want to pull this branch down to your local and run the ol'
drush updb -y, any attempts to login or update your profile should log the corresponding Northstar requests to thedosomething_northstar_request_logtable. Like so:Any background context you want to provide?
Nah. See the relevant ticket below.
What are the relevant tickets?
References #6260.
For review: @angaither