This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Signups API - Join bug on Reportbacks and Drupal Logs#6268
Merged
chloealee merged 3 commits intoDoSomethingArchive:devfrom Mar 14, 2016
Merged
Signups API - Join bug on Reportbacks and Drupal Logs#6268chloealee merged 3 commits intoDoSomethingArchive:devfrom
chloealee merged 3 commits intoDoSomethingArchive:devfrom
Conversation
chloealee
changed the title
Contributor
|
👍 |
chloealee
added a commit
that referenced
this pull request
Mar 14, 2016
Signups API - Join bug on Reportbacks and Druapal Logs
chloealee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Changed the query to make sure that campaign runs also equal each other, not just campaign nodes.
Added more explicit check to make sure
!empty($northstar_response->data)to get rid of db logs.How should this be manually tested?
Make sure that each signup has a unique Reportback ID. (can use https://www.dosomething.org/api/v1/signups?user=1176550&campaigns=362 in prod)
What are the relevant tickets?
Fixes #6266