This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Fixes SMS game active view#6271
Merged
katiecrane merged 3 commits intoDoSomethingArchive:devfrom Mar 15, 2016
Merged
Conversation
| // @see dosomething_campaign_menu(). | ||
| $active_path = 'node/' . $node->nid . '/active'; | ||
| if ($current_path == $active_path) { | ||
| if(dosomething_campaign_get_campaign_type($node) == 'sms_game') { |
Contributor
There was a problem hiding this comment.
a comment inspired by @sergii-tkachenko use ===
Contributor
|
👍 cc @namimody |
Contributor
|
Thanks @angaither and @katiecrane! And does the SMS active view also appear if the SMS game is open? |
Contributor
Author
|
@namimody Yeah it shows up correctly, but just under view and not active. The active view is only available if the campaign is closed. That's my understanding at least. |
Contributor
|
Hi @katiecrane! Got it, thanks. Going to make a separate issue for the weird /edit view that currently exists for active SMS campaigns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Fixes SMS game active view to show up as an SMS game and not a regular campaign.
How should this be manually tested?
As an admin, go to a closed SMS campaign and go into the active view. It should show up like an SMS game and not a campaign. It should only be calling the
dosomething_campaign_preprocess_sms_gameif you are on the active path so I don't think it should be messing anything else up.Any background context you want to provide?
I made the fix that @aaronschachter suggested in the issue and it seems to work.
What are the relevant tickets?
Fixes #4488