This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Remove code that updates a signup run if no signup on the current run…#6278
Merged
Remove code that updates a signup run if no signup on the current run…#6278
Conversation
… is found. This was added in to support #6095 when signup run ids were null or 0 But our main man, sharron, found a crazy bug that this causes. Essentailly if you signup for a campaign, but don't reportback We close the campaign Open the campaign with a new run Go to view the campaign with from the doing section on your profile The signup you had for the previous run, will get updated to the current run. Fixes #6269
Contributor
|
👍 |
angaither
added a commit
that referenced
this pull request
Mar 15, 2016
Remove code that updates a signup run if no signup on the current run…
Contributor
|
Do we need to run an update for existing activity for users who might have had the same thing happen to me in #6269 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
removes code introduced in #6098
How should this be manually tested?
lord. don't get me started.
it's difficult. see background context.
you basically just need to test that signing up still works.
Any background context you want to provide?
This was added in to support #6095 when signup run ids were null or 0
But our main man, sharron, found a crazy bug that this causes.
Essentially if you signup for a campaign, but don't reportback
We close the campaign
Open the campaign with a new run
Go to view the campaign with from the doing section on your profile
The signup you had for the previous run, will get updated to the current run.
What are the relevant tickets?
Fixes #6269