This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Merged
Conversation
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Script to bulk exclude any fids for node 362 (campaign runs 5439 or 2341) that are pending and whose reportback has a quantity of less than 200. This is a fix for #6353 .
How should this be manually tested?
When ssh'd in your vagrant environment, run
drush updb -yindosomething@dev:/var/www/dev.dosomething.org/html$Check
http://dev.dosomething.org:8888/us/node/362/rb/and onlyfidswith a quantity over 200 should still be pending and appear in the inbox.Any background context you want to provide?
Is an update to #6353 .
To test on my local, I added a reportback with 2 reportback items. I ran the script and saw that both reportback items statuses were changed to
excludedand the parent reportbackflaggedstatus changed to0.Then, I added two more reportback items and changed one
statustoflaggedand the parent reportbackflaggedstatus to1. I ran the script and the second reportback item's status updated toexcludedand the reportbackflaggedstatus remained as1.What are the relevant tickets?
Fixes #6344