This repository was archived by the owner on Oct 29, 2020. It is now read-only.
More Northstar sync fixes#6411
Merged
DFurnes merged 12 commits intoDoSomethingArchive:devfrom May 10, 2016
DFurnes:northstar-migrate-touchups
Merged
More Northstar sync fixes#6411DFurnes merged 12 commits intoDoSomethingArchive:devfrom DFurnes:northstar-migrate-touchups
DFurnes merged 12 commits intoDoSomethingArchive:devfrom
DFurnes:northstar-migrate-touchups
Conversation
This was previously loading user out of order (perhaps because some of the low UIDs were added manually?) which made it look like people were getting skipped when skimming logs.
We encode JSON in this script, and then again in the function so this is not necessary!
This allows us to make the call without needing a full form array to rebuild the query (for example, so we can chain a “register” call after an “update” call).
We’ve had some “update” calls result in 404s, so try to create those users when that occurs.
Some users have a last name set on their profile. If we have it, we should send that to Northstar!
Contributor
|
👍 |
This was referenced May 10, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
This PR fixes a number of smaller issues with Northstar migration and syncing. The highlights:
1234445555@mobile"placeholder" emails were being sent with mobile users and causing validation errors on Phoenix. These are now ignored when forming the payload. (cc3640b)phoenixas the signup source. This was previously only happening for batch migrated users. (0096db3)build_ns_usercall out of the methods which make the HTTP requests to Northstar (c946d7b). This allows us to easily chain another request to register a user if the "update" request failed without having to try to re-build the whole user object. (9492787)I'd recommend reviewing commit-by-commit since otherwise some of the changes get jumbled.
How should this be manually tested?
I've tested by manually checking that users are created/updated against my local Northstar, and by adding
dpmcalls to trace which hooks/methods get called.Any background context you want to provide?
I'm not 100% sure that triggering a "register" whenever an "update" call fails will work... I feel like there might be some sort of conflict that's preventing those users from being registered in the first place. But it'll help surface that issue if so, and if not it's a nice way to "stop the bleeding" while continuing to investigate to figure out the underlying issue. 🔍
What are the relevant tickets?
References #6406 and #6260.
For review: @angaither