This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Merged
Conversation
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
This PR updates the
dosomething_global_get_prefix_for_language()function to allow it to fallback to no prefix returned for the URL (thus a global URL) if the passed$languageisn't found in the list of supported languages. Prior to this, if somehow a language was passed that wasn't supported, we'd get lots of logged error notices.How should this be reviewed?
Pull down the branch, use ModHeader chrome extension to pretend you're coming in from Canada, load the site and check the logs. If there are no errors regarding
Undefined index: en-ca in dosomething_global_get_prefix_for_language()then all should be good.Any background context you want to provide?
This is only part of a fix that may be related to the larger issue in #6488
Relevant tickets
Refs #6488
@angaither @joe