This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Merged
Conversation
Start roughly mocking out the different screens we need
…irements for the request Pass sid to the front end using the drupal.settings object Store registration in phoenix db when submit button is clicked.
| * organ donation modal after signup. | ||
| * | ||
| */ | ||
| function dosomething_campaign_organ_donation_config_form($form, &$form_state, $node) { |
Contributor
Author
There was a problem hiding this comment.
Now that i'm looking at it, i feel like this admin config stuff should be housed in the dosomething_organ_donation module. But it's not a blocker for merge, I don't think...
Refactor how we check if someone has registered so it is more readable
Contributor
Author
|
@angaither I moved the all the admin stuff for the organ donation configuration into the @DFurnes thanks for your comments! i didn't know about |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
This PR does a few things:
Takeover.jsinjects content into the modal and handles everything from there. But we also check that the users hasn't yet submitted the registration form before deciding if we should show it or not. hereTakeover.js, this PR, starts to roughly mock out how the modal will work for organ donations. We pull in some underscore templates that house the content for each "screen" in the modal. Flow is like:How should this be reviewed?
Pull branch down. Make sure you have the
dosomething_organ_donationmodule turned on. Go to a campaign and turn on organ donation in the custom settings form.Now, sign up for the campaign (preferably as a new user or anon user since that is what most of the folks will be) when you get taken to the action page, you should see the modal. And the experience should work like what is outlined above.
Any background context you want to provide?
This is not final at all, but covers the ability to show a modal after a user signs up for a campaign and allows us to start making API calls from within that modal. Please see my notes here about some of the JS and how I would like to refactor it.
Relevant tickets
Fixes #6481
@angaither @DFurnes @weerd @chloealee