This repository was archived by the owner on Oct 29, 2020. It is now read-only.
Only displays partners if translated#6528
Merged
itsjoekent merged 3 commits intoDoSomethingArchive:devfrom May 31, 2016
Merged
Conversation
| $request_path = explode('/', request_path()); | ||
| if (!empty($request_path[0])) { | ||
|
|
||
| // If the string is longer than a country code |
Contributor
Author
There was a problem hiding this comment.
campaigns -- but if the default language was Spanish/Mexico, this would be voluntario
basically,
/campaigns/something = global
/us/campaigns/something = not global
in the first case the [0] is the campaigns, and this new line of code catches that
Contributor
There was a problem hiding this comment.
we should be able to follow the way we determine language in other places instead of updating this
added 2 commits
May 31, 2016 16:56
Contributor
Author
|
@angaither seems to work with the way you suggested, removed the global change and also updated the default param to be en-global |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
How should this be reviewed?
First visit a campaign page that has a partner term set.
Then translate this campaign, but NOT the partner term. Does it show in the info bar still?
Also because I changed the global get lang function, make sure the site routing still seems ok.
Relevant tickets
Fixes #6379