Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Commit 33d2076

Browse files
committed
Merge pull request #4099 from sergii-tkachenko/fix-more-reportback-xss
Fix more reportback XSS vulnerabilities.
2 parents 9d16309 + 5e13e35 commit 33d2076

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

lib/themes/dosomething/paraneue_dosomething/templates/campaign/node--campaign--closed.tpl.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@
117117
<?php endif; ?>
118118
<div class="figure__body">
119119
<?php if (isset($reportback_gallery_item['first_name'])): ?>
120-
<h3><?php print $reportback_gallery_item['first_name']; ?></h3>
120+
<h3><?php print check_plain($reportback_gallery_item['first_name']); ?></h3>
121121
<?php endif; ?>
122122
<?php if (isset($reportback_gallery_item['caption'])): ?>
123123
<?php print check_plain($reportback_gallery_item['caption']); ?>

lib/themes/dosomething/paraneue_dosomething/templates/campaign/partials/campaign-creator.tpl.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<img src="<?php print $picture['src_square']; ?>" />
2424
</div>
2525
<div class="__body">
26-
<h4 class="__title heading -delta"><?php print $first_name; ?> <?php print $last_initial; ?></h4>
26+
<h4 class="__title heading -delta"><?php print checl_plain($first_name); ?> <?php print $last_initial; ?></h4>
2727
<p class="__location"><?php print $city; ?>, <?php print $state; ?></p>
2828
<div class="copy"><?php print $copy; ?></div>
2929
<div class="form-actions">

lib/themes/dosomething/paraneue_dosomething/templates/reportback/reportback-permalink.tpl.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,15 @@
1919
<?php echo $copy_vars['owners_rb_subtitle'] ?>
2020
<?php echo $copy_vars['owners_rb_scholarship'] ?>
2121
<?php echo check_plain($reportback->caption) ?>
22-
<?php echo $user->first_name ?>
22+
<?php echo check_plain($user->first_name) ?>
2323

2424
<h3>
2525
<?php echo $copy_vars['owners_rb_important'] ?>
2626
</h3>
27-
<?php echo $reportback->why_participated ?>
27+
<?php echo check_plain($reportback->why_participated) ?>
2828

29-
<?php echo $reportback->quantity ?> <?php echo $reportback->quantity_label ?>
29+
<?php echo check_plain($reportback->quantity) ?>&nbsp;
30+
<?php echo $reportback->quantity_label ?>
3031

3132

3233

0 commit comments

Comments
 (0)