Rename id to drupal_id to make clearer.

Was ambiguous what kind of ID it was without reading implementation.

Author: DFurnes

lib/modules/dosomething/dosomething_northstar/dosomething_northstar.module

@@ -172,27 +172,27 @@ function dosomething_northstar_update_user($form_state) {
  * @param int $drupal_id Drupal user id.
  * @return object
  */
-function dosomething_northstar_get_northstar_user($id) {
-  $northstar_user_info = cache_get('northstar_user_info_' . $id, 'cache_dosomething_northstar');
+function dosomething_northstar_get_northstar_user($drupal_id) {
+  $northstar_user_info = cache_get('northstar_user_info_' . $drupal_id, 'cache_dosomething_northstar');
 
   if ($northstar_user_info) {
     $northstar_user_info = $northstar_user_info->data;
   }
   else {
     $client = _dosomething_northstar_build_http_client();
 
-    $northstar_user_info = drupal_http_request($client['base_url'] . '/users/drupal_id/' . $id, array(
+    $northstar_user_info = drupal_http_request($client['base_url'] . '/users/drupal_id/' . $drupal_id, array(
       'headers' => $client['headers'],
       'method' => 'GET',
       ));
 
       $northstar_user_info = $northstar_user_info->data;
 
       if (!empty($northstar_user_info->error)) {
-        $error = sprintf("Error fetching Northstar user data, uid=%d: '%s'", $id, $northstar_user_info->error);
+        $error = sprintf("Error fetching Northstar user data, uid=%d: '%s'", $drupal_id, $northstar_user_info->error);
         watchdog_exception('northstar', new Exception($error));
       } else {
-        cache_set('northstar_user_info_' . $id, $northstar_user_info, 'cache_dosomething_northstar', REQUEST_TIME + 60*60*24);
+        cache_set('northstar_user_info_' . $drupal_id, $northstar_user_info, 'cache_dosomething_northstar', REQUEST_TIME + 60*60*24);
       }
   }