Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Commit e62f821

Browse files
committed
Merge pull request #1569 from weerd/11-facts--sources-output
11 facts sources output
2 parents 23515c4 + 3e32988 commit e62f821

File tree

3 files changed

+10
-19
lines changed

3 files changed

+10
-19
lines changed

lib/modules/dosomething/dosomething_fact_page/dosomething_fact_page.features.field_instance.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ function dosomething_fact_page_field_default_field_instances() {
4242
'label' => 'Sources',
4343
'required' => 0,
4444
'settings' => array(
45-
'text_processing' => 0,
45+
'text_processing' => 1,
4646
'user_register_form' => FALSE,
4747
),
4848
'widget' => array(

lib/themes/dosomething/paraneue_dosomething/scss/content/_fact-page.scss

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,10 @@
9898
}
9999
}
100100

101-
.sources {
102-
// @TODO: I just made sources small for now, need to revisit their structure
103-
p {
104-
font-size: $font-small;
101+
.sources { margin-bottom: 1rem;
102+
li {
105103
color: $med-gray;
104+
font-size: $font-small;
106105
}
107106
}
108107
}

lib/themes/dosomething/paraneue_dosomething/templates/node--fact_page.tpl.php

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
</header>
1212
</div>
1313

14-
14+
1515
<?php if (isset($intro)): ?>
1616
<div class="intro-wrapper">
1717
<div class="intro">
@@ -39,30 +39,22 @@
3939
<p class="fact">
4040
<?php print ($key + 1) . '. ' . $fact['fact']; ?>
4141

42-
<?php // @TODO: Temporarily commented out until the new 'sources' solution in campaigns is implemented and we can use it here! ?>
42+
<?php // @TODO: Sources reinstated, but not sure if the facts need to have numbers associated with their respective source? Need to clarify. ?>
4343
<?php //<sup></?php print $fact['footnotes']; ?/></sup> ?>
4444
</p>
4545
<?php endforeach; ?>
4646
</div>
4747
</div>
4848
<?php endif; ?>
49-
50-
<?php // @TODO: Temporarily commented out until the new 'sources' solution in campaigns is implemented and we can use it here! ?>
51-
<?php /*
49+
5250
<?php if (isset($sources)): ?>
5351
<div class="sources-wrapper">
5452
<div class="sources">
5553
<h4>Sources</h4>
56-
<?php foreach ($sources as $key => $source): ?>
57-
<div class="source">
58-
<?php // @TODO: Need <sup> to print within the $source's <p> tag. Source markup needs a rework. ?>
59-
<sup><?php print ($key + 1); ?></sup><?php print $source; ?>
60-
</div>
61-
<?php endforeach; ?>
62-
</div>
54+
<?php print $sources; ?>
55+
</div>
6356
</div>
6457
<?php endif; ?>
65-
*/ ?>
6658

6759
<?php if (isset($call_to_action)): ?>
6860
<div class="cta-wrapper">
@@ -73,4 +65,4 @@
7365
</div>
7466
<?php endif; ?>
7567
</article>
76-
</section>
68+
</section>

0 commit comments

Comments
 (0)