Skip to content

Commit 1b56c29

Browse files
authored
[chore] Let renovatebot run actions (open-telemetry#30112)
**Description:** We ran into an issue today where open-telemetry#30091 was mergable because [skipped tests count as success](https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution#overview). If the CI had been allowed to run, the PR would not have been mergable. So, despite this meaning we'll be running a bunch of useless actions for most renovatebot PRs, we are re-enabling actions for renovatebot for now to protect ourselves.
1 parent 433048a commit 1b56c29

File tree

9 files changed

+12
-13
lines changed

9 files changed

+12
-13
lines changed

.github/workflows/build-and-test-windows.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- cmd
3737
- other
3838
runs-on: windows-latest
39-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' && (contains(github.event.pull_request.labels.*.name, 'Run Windows') || github.event_name == 'push') }}
39+
if: ${{ github.actor != 'dependabot[bot]' && (contains(github.event.pull_request.labels.*.name, 'Run Windows') || github.event_name == 'push') }}
4040
env:
4141
# Limit memory usage via GC environment variables to avoid OOM on GH runners, especially for `cmd/otelcontribcol`,
4242
# see https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/28682#issuecomment-1802296776
@@ -66,7 +66,7 @@ jobs:
6666
- name: Run Unit tests
6767
run: make -j2 gotest GROUP=${{ matrix.group }}
6868
windows-unittest:
69-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' && (contains(github.event.pull_request.labels.*.name, 'Run Windows') || github.event_name == 'push') }}
69+
if: ${{ github.actor != 'dependabot[bot]' && (contains(github.event.pull_request.labels.*.name, 'Run Windows') || github.event_name == 'push') }}
7070
runs-on: windows-latest
7171
needs: [windows-unittest-matrix]
7272
steps:

.github/workflows/build-and-test.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
setup-environment:
2121
timeout-minutes: 30
2222
runs-on: ubuntu-latest
23-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' }}
23+
if: ${{ github.actor != 'dependabot[bot]' }}
2424
steps:
2525
- uses: actions/checkout@v4
2626
- uses: actions/setup-go@v5
@@ -105,7 +105,7 @@ jobs:
105105
- name: Lint
106106
run: make -j2 golint GROUP=${{ matrix.group }}
107107
lint:
108-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' && always() }}
108+
if: ${{ github.actor != 'dependabot[bot]' && always() }}
109109
runs-on: ubuntu-latest
110110
needs: [setup-environment, lint-matrix]
111111
steps:
@@ -134,7 +134,6 @@ jobs:
134134
- internal
135135
- pkg
136136
runs-on: ubuntu-latest
137-
if: ${{ github.actor != 'renovate[bot]' }}
138137
timeout-minutes: 30
139138
steps:
140139
- name: Checkout Repo
@@ -277,7 +276,7 @@ jobs:
277276
name: coverage-artifacts
278277
path: ${{ matrix.group }}-coverage.txt
279278
unittest:
280-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' && always() }}
279+
if: ${{ github.actor != 'dependabot[bot]' && always() }}
281280
runs-on: ubuntu-latest
282281
needs: [setup-environment, unittest-matrix]
283282
steps:

.github/workflows/changelog.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ concurrency:
2323
jobs:
2424
changelog:
2525
runs-on: ubuntu-latest
26-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' }}
26+
if: ${{ github.actor != 'dependabot[bot]' }}
2727
env:
2828
PR_HEAD: ${{ github.event.pull_request.head.sha }}
2929

.github/workflows/check-links.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
runs-on: ubuntu-latest
1616
env:
1717
PR_HEAD: ${{ github.event.pull_request.head.sha }}
18-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' }}
18+
if: ${{ github.actor != 'dependabot[bot]' }}
1919
outputs:
2020
md: ${{ steps.changes.outputs.md }}
2121
steps:

.github/workflows/codeql-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
jobs:
88
CodeQL-Build:
99
runs-on: macos-latest
10-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' }}
10+
if: ${{ github.actor != 'dependabot[bot]' }}
1111
env:
1212
# Force CodeQL to run the extraction on the files compiled by our custom
1313
# build command, as opposed to letting the autobuilder figure it out.

.github/workflows/e2e-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ env:
1414
jobs:
1515
collector-build:
1616
runs-on: ubuntu-latest
17-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' }}
17+
if: ${{ github.actor != 'dependabot[bot]' }}
1818
steps:
1919
- name: Checkout
2020
uses: actions/checkout@v4

.github/workflows/load-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
setup-environment:
2020
timeout-minutes: 30
2121
runs-on: self-hosted
22-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' }}
22+
if: ${{ github.actor != 'dependabot[bot]' }}
2323
outputs:
2424
loadtest_matrix: ${{ steps.splitloadtest.outputs.loadtest_matrix }}
2525
steps:

.github/workflows/prometheus-compliance-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ env:
1919
jobs:
2020
prometheus-compliance-tests:
2121
runs-on: ubuntu-latest
22-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' }}
22+
if: ${{ github.actor != 'dependabot[bot]' }}
2323
steps:
2424
- uses: actions/checkout@v4
2525
with:

.github/workflows/telemetrygen.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ concurrency:
1414
jobs:
1515
build-dev:
1616
runs-on: ubuntu-latest
17-
if: ${{ github.actor != 'dependabot[bot]' && github.actor != 'renovate[bot]' }}
17+
if: ${{ github.actor != 'dependabot[bot]' }}
1818
steps:
1919
- uses: actions/checkout@v4
2020
- name: Set up QEMU

0 commit comments

Comments
 (0)