Skip to content

Commit 606f7cc

Browse files
authored
[chore] Fix more load test pipeline issues (open-telemetry#33885)
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR fixes more issues with the load test pipeline. Specifically, it adjusts some things around artifact up/download which is needed as a result of the breaking changes in GitHub Actions artifacts listed [here](https://github.com/actions/upload-artifact#breaking-changes:~:text=Uploading%20to%20the%20same%20named,you%20will%20encounter%20an%20error.). Also, it removes the issue generation step which seems far outdated as it's failing with missing CircleCI env variables. Also, I noticed that a few of the load tests fail consistently. To test. the pipeline, I had to comment them out. Not sure, what to do with them... **Link to tracking Issue:** Part of open-telemetry#33577 Follow up to open-telemetry#33860 **Testing:** Testing done on my personal fork. Link to working pipeline run: [Green run with some broken tests commented out, but pipeline working](https://github.com/mowies/opentelemetry-collector-contrib/actions/runs/9789652148) [Red run with broken tests](https://github.com/mowies/opentelemetry-collector-contrib/actions/runs/9790395589) **Documentation:** none added --------- Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
1 parent 2c931a7 commit 606f7cc

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

.github/workflows/load-tests.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ jobs:
9696
env:
9797
TEST_ARGS: "-test.run=${{ matrix.test }}"
9898
- name: Set results filename
99+
if: ${{ failure() || success() }}
99100
id: filename
100101
run: echo "name=$(echo '${{ matrix.test }}' | sed -e 's/|/_/g')" >> $GITHUB_OUTPUT
101102
- name: Create Test Result Archive
@@ -107,18 +108,15 @@ jobs:
107108
continue-on-error: true
108109
uses: actions/upload-artifact@v4
109110
with:
111+
name: test-result-archive-${{steps.filename.outputs.name}}
110112
path: ./*.tar
111113
- run: cp testbed/tests/results/benchmarks.json testbed/tests/results/${{steps.filename.outputs.name}}.json
112114
- name: Upload benchmarks.json
113115
uses: actions/upload-artifact@v4
114116
with:
115-
name: benchmark-results
117+
name: benchmark-results-${{steps.filename.outputs.name}}
116118
path: testbed/tests/results/${{steps.filename.outputs.name}}.json
117119

118-
- name: GitHub Issue Generator
119-
if: ${{ failure() && github.ref == 'refs/heads/main' }}
120-
run: ./.tools/issuegenerator $TEST_RESULTS
121-
122120
update-benchmarks:
123121
runs-on: ubuntu-latest
124122
needs: [loadtest]
@@ -127,7 +125,8 @@ jobs:
127125
- uses: actions/checkout@v4
128126
- uses: actions/download-artifact@v4
129127
with:
130-
name: benchmark-results
128+
pattern: benchmark-results-*
129+
merge-multiple: true
131130
path: results
132131
- run: jq -s 'map(.[])' results/*.json > output.json
133132
- uses: benchmark-action/github-action-benchmark@v1

0 commit comments

Comments
 (0)