Commit c71919f
authored
[chore][receiver/vcenter] Reworked Integration test for vCenter (open-telemetry#34201)
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The following PR works to make the integration tests a bit more
deterministic by taking advantage of the govmomi simulator. Previously
the integration test had the following line when comparing
```
pmetrictest.IgnoreResourceAttributeValue("vcenter.host.name")
```
Which is a bit of a hacky fix that addressed an issue where the
simulator had inconsistent VM to Host assignments between test runs.
Although ignoring the resource attribute value currently works, it
breaks once datacenter metrics are enabled by default
This PR hopes to make the integration tests more consistent and accurate
going forward.
**Link to tracking Issue:** <Issue number if applicable>
**Testing:** <Describe what testing was performed and which tests were
added.>
- Regenerated the expected.yaml using `scraperinttest.WriteExpected()`
- Passes Integration test
**Documentation:** <Describe the documentation added.>1 parent e32faef commit c71919f
File tree
2 files changed
+486
-440
lines changed- receiver/vcenterreceiver
- testdata/integration
2 files changed
+486
-440
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
29 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
30 | 76 | | |
31 | 77 | | |
32 | 78 | | |
| |||
51 | 97 | | |
52 | 98 | | |
53 | 99 | | |
54 | | - | |
55 | 100 | | |
56 | 101 | | |
57 | 102 | | |
| |||
66 | 111 | | |
67 | 112 | | |
68 | 113 | | |
69 | | - | |
70 | 114 | | |
71 | 115 | | |
| 116 | + | |
| 117 | + | |
72 | 118 | | |
73 | 119 | | |
74 | 120 | | |
| |||
0 commit comments