From 97dfa056c9077011a65b44393c914d66942daf79 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 11 Apr 2023 13:31:55 +0930 Subject: [PATCH 1/2] doc: give helpful examples for feerate values. mempool.info gives sat/vB, which is 1000 too low for us! See-also: #6161 (complains setting feerate to 5 doesn't work) See-also: #6129 Suggested-by: @lightingorb Signed-off-by: Rusty Russell --- doc/lightning-feerates.7.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/lightning-feerates.7.md b/doc/lightning-feerates.7.md index 76dcaece31d8..a374e7e41355 100644 --- a/doc/lightning-feerates.7.md +++ b/doc/lightning-feerates.7.md @@ -17,8 +17,11 @@ CLN will also smoothen feerate estimations from the backend. *style* is either of the two strings: -* *perkw* - provide feerate in units of satoshis per 1000 weight. -* *perkb* - provide feerate in units of satoshis per 1000 virtual bytes. +* *perkw* - provide feerate in units of satoshis per 1000 weight (e.g. the minimum fee is usually `253perkw`) +* *perkb* - provide feerate in units of satoshis per 1000 virtual bytes (eg. the minimum fee is usually `1000perkb`) + +Explorers often present fees in "sat/vB": 4 sat/vB is `4000perkb` or +`1000perkw`. Bitcoin transactions have non-witness and witness bytes: From ca5976a06eef4385ec1664e554920ef705621260 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Tue, 11 Apr 2023 13:34:57 +0930 Subject: [PATCH 2/2] doc: document that urgent doesn't use the 2-block estimate, but the 6-block. Turns out this was accidentally changed for v0.10.1 in d8e68893f5f7d83bc70bd27630df6dcd9aac6735 where we made fee levels less aggressive. Oops. I guess we can fix the docs. And we now have "2blocks" if you want it really fast! Closes: #6129 Changelog-Fixed: JSON-RPC: `feerates` document correctly that urgent means 6 blocks (not 2), and give better feerate examples. Signed-off-by: Rusty Russell --- doc/lightning-feerates.7.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/lightning-feerates.7.md b/doc/lightning-feerates.7.md index a374e7e41355..c1ca58368644 100644 --- a/doc/lightning-feerates.7.md +++ b/doc/lightning-feerates.7.md @@ -104,8 +104,8 @@ NOTES Many other commands have a *feerate* parameter. This can be: * One of the strings to use lightningd's internal estimates: - * *urgent* (aim for next block), - * *normal* (next 6 blocks or so) + * *urgent* (next 6 blocks or so) + * *normal* (next 12 blocks or so) * *slow* (next 100 blocks or so) * *minimum* for the lowest value bitcoind will currently accept (added in v23.05)