From 50ce63ec01c30b5513cab3025bf4a3cb1f2649f8 Mon Sep 17 00:00:00 2001
From: Weiran Ye <yeweiran1995@gmail.com>
Date: Thu, 27 May 2021 18:56:17 -0700
Subject: [PATCH] Fix SignatureHelp block other vscode extension issue

---
 .../main/kotlin/com/tang/vscode/LuaTextDocumentService.kt | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/EmmyLua-LS/src/main/kotlin/com/tang/vscode/LuaTextDocumentService.kt b/EmmyLua-LS/src/main/kotlin/com/tang/vscode/LuaTextDocumentService.kt
index dd54fca5..373368db 100644
--- a/EmmyLua-LS/src/main/kotlin/com/tang/vscode/LuaTextDocumentService.kt
+++ b/EmmyLua-LS/src/main/kotlin/com/tang/vscode/LuaTextDocumentService.kt
@@ -383,8 +383,9 @@ class LuaTextDocumentService(private val workspace: LuaWorkspaceService) : TextD
 
     }
 
-    override fun signatureHelp(position: TextDocumentPositionParams): CompletableFuture<SignatureHelp> {
+    override fun signatureHelp(position: TextDocumentPositionParams): CompletableFuture<SignatureHelp?> {
         return computeAsync {
+            var signatureHelp: SignatureHelp? = null
             val list = mutableListOf<SignatureInformation>()
             var activeParameter = 0
             var activeSig = 0
@@ -427,7 +428,10 @@ class LuaTextDocumentService(private val workspace: LuaWorkspaceService) : TextD
                     }
                 }
             }
-            SignatureHelp(list, activeSig, activeParameter)
+            if (list.size > 0) {
+                signatureHelp = SignatureHelp(list, activeSig, activeParameter)
+            }
+            signatureHelp
         }
     }