test: Phase 4 QA — comprehensive tests for Phase 3 core fixes

tests/test_normalize_project.py

@@ -0,0 +1,61 @@
+"""Tests for project name normalization in MCP server."""
+
+import os
+
+from brainlayer.mcp import normalize_project_name
+
+
+class TestNormalizeProjectName:
+    """Test Claude Code path encoding → clean project name."""
+
+    def test_none_returns_none(self):
+        assert normalize_project_name(None) is None
+
+    def test_empty_returns_none(self):
+        assert normalize_project_name("") is None
+        assert normalize_project_name("  ") is None
+        assert normalize_project_name("-") is None
+
+    def test_simple_name_passthrough(self):
+        """Already-clean names pass through unchanged."""
+        assert normalize_project_name("golems") == "golems"
+
+    def test_claude_code_encoded_path(self):
+        """Standard Claude Code path encoding decodes correctly."""
+        # This test requires the actual filesystem to have ~/Gits/golems
+        result = normalize_project_name("-Users-etanheyman-Gits-golems")
+        assert result == "golems"
+
+    def test_desktop_gits_path(self):
+        """Old Desktop/Gits paths decode correctly."""
+        # Old path — directory may not exist, but first segment is returned
+        result = normalize_project_name("-Users-etanheyman-Desktop-Gits-golems")
+        # Either finds the dir or falls back to first segment
+        assert result is not None
+
+    def test_compound_name_with_dashes(self):
+        """Compound project names with dashes resolve via filesystem check."""
+        # Only works if the directory actually exists
+        home = os.path.expanduser("~")
+        gits_dir = os.path.join(home, "Gits")
+        if os.path.isdir(gits_dir):
+            for entry in os.listdir(gits_dir):
+                if "-" in entry and os.path.isdir(os.path.join(gits_dir, entry)):
+                    # Test that this compound name resolves correctly
+                    encoded = f"-Users-{os.path.basename(home)}-Gits-{entry.replace('-', '-')}"
+                    # The encoding is just dashes, same as the name
+                    # Just verify it doesn't crash
+                    result = normalize_project_name(encoded)
+                    assert result is not None
+                    break
+
+    def test_worktree_suffix_stripped(self):
+        """Worktree suffixes are stripped."""
+        assert normalize_project_name("golems-nightshift-1770775282043") == "golems"
+        assert normalize_project_name("golems-haiku-1770775282043") == "golems"
+        assert normalize_project_name("golems-worktree-1770775282043") == "golems"
+
+    def test_no_gits_segment_returns_none(self):
+        """Paths without 'Gits' segment return None."""
+        result = normalize_project_name("-Users-etanheyman-Documents-stuff")
+        assert result is None

tests/test_paths.py

@@ -0,0 +1,50 @@
+"""Tests for brainlayer.paths — DB path resolution."""
+
+import os
+from unittest.mock import patch
+
+from brainlayer.paths import get_db_path
+
+
+class TestGetDbPath:
+    """Test DB path resolution order."""
+
+    def test_env_var_override(self, tmp_path):
+        """BRAINLAYER_DB env var takes highest priority."""
+        db_path = tmp_path / "custom.db"
+        with patch.dict(os.environ, {"BRAINLAYER_DB": str(db_path)}):
+            assert get_db_path() == db_path
+
+    def test_legacy_path_if_exists(self, tmp_path):
+        """Legacy zikaron path used when it exists."""
+        legacy = tmp_path / "zikaron.db"
+        legacy.touch()
+        with (
+            patch.dict(os.environ, {}, clear=True),
+            patch("brainlayer.paths._LEGACY_DB_PATH", legacy),
+            patch("brainlayer.paths._CANONICAL_DB_PATH", tmp_path / "brainlayer.db"),
+        ):
+            # Remove env var if set
+            os.environ.pop("BRAINLAYER_DB", None)
+            assert get_db_path() == legacy
+
+    def test_canonical_path_fresh_install(self, tmp_path):
+        """Canonical path used when no legacy DB exists."""
+        canonical = tmp_path / "brainlayer" / "brainlayer.db"
+        legacy = tmp_path / "nonexistent" / "zikaron.db"
+        with (
+            patch.dict(os.environ, {}, clear=True),
+            patch("brainlayer.paths._LEGACY_DB_PATH", legacy),
+            patch("brainlayer.paths._CANONICAL_DB_PATH", canonical),
+        ):
+            os.environ.pop("BRAINLAYER_DB", None)
+            result = get_db_path()
+            assert result == canonical
+            assert canonical.parent.exists()  # Parent dir created
+
+    def test_real_db_exists(self):
+        """The real production DB exists at the resolved path."""
+        from brainlayer.paths import DEFAULT_DB_PATH
+
+        assert DEFAULT_DB_PATH.exists(), f"DB not found at {DEFAULT_DB_PATH}"
+        assert DEFAULT_DB_PATH.stat().st_size > 1_000_000, "DB too small — might be empty"