docs: nightly sweep — test count 929, CHANGELOG entries for #65-#78#81
Conversation
|
@codex review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e551e14be9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| del store # Retained for signature compatibility. | ||
| conn = _open_checkpoint_conn() | ||
| try: |
There was a problem hiding this comment.
resume_backfill(db_path=...) now passes a DB-specific store, but get_pending_jobs discards that store and reads from a process-global sidecar DB instead. In environments that run backfill against multiple --db paths, pending jobs from one database can be resumed/imported while connected to another, which risks importing enrichment results into the wrong dataset.
Useful? React with 👍 / 👎.
| elif list(EXPORT_DIR.glob("batch_*.jsonl")): | ||
| print("All existing JSONL batch files are already checkpointed. No new submissions needed.") | ||
| return |
There was a problem hiding this comment.
In --submit-only mode, this branch returns as soon as it sees any existing batch_*.jsonl files that are already checkpointed, so it never calls export_unenriched_chunks for newly-added unenriched rows. After one completed run leaves files in EXPORT_DIR, later submit-only runs can incorrectly report “No new submissions needed” even when new chunks exist.
Useful? React with 👍 / 👎.
| if now - cached_at < _HYBRID_CACHE_TTL: | ||
| _hybrid_cache.move_to_end(cache_key) # LRU touch | ||
| return _clone_hybrid_result(cached_result) |
There was a problem hiding this comment.
This cache hit path returns previous results without touching the DB, but the new module-level cache has no invalidation tied to brain_store/update/import flows. If a user repeats a query shortly after writing or modifying memories, retrieval can remain stale for up to the 60s TTL, which is a correctness regression for immediate recall behavior.
Useful? React with 👍 / 👎.
1 participant
Summary
Changes
README.md— test badge + banner stat: 715 → 929CHANGELOG.md— [Unreleased] expanded with ~15 new entries covering 2 months of PRsAGENTS.md— test count updated to 929Part of nightly docs sweep 2026-03-14.