fix(ce-work): probe ignored snapshot capability before dispatch - #1302
Merged
tmchow merged 2 commits intoAug 1, 2026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2caf468bc5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
|
Nice fix @nathanvale |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepare, before external authoring starts.This is a containment fix for #1300. It stops users paying for external authoring that cannot integrate; it does not change ignored snapshot semantics.
Motivation
The reported real checkout has 12,345 ignored entries: 12,100 regular files, 219 symlinks, 26 opaque directory entries, and about 623 MB of regular payload. The existing 512-entry / 64 MiB snapshot limits and unsupported entry representations only refuse after external authoring has completed.
Validation
python3 -m py_compile skills/ce-work/scripts/unit_workspace_ignored.py skills/ce-work/scripts/unit_workspace_jobs.py skills/ce-work/scripts/unit_workspace_transaction.pybun test tests/skills/ce-work-unit-workspace.test.ts(85 passed)bun run test(2,871 passed)bun run release:validateFixtures use scratch Git repositories and cover entry cap, byte cap, symlink, multi-link file, ownership mismatch, opaque directory entry, and all-clear pass-through. I can also validate this branch against the measured 12.3k-entry checkout shape if useful.
Security Disclosure
Adds read-only filesystem metadata and ownership inspection before external dispatch. The probe uses the existing bounded Git ignored inventory and path-containment checks, performs no copy or mutation, and returns a bounded 10-entry offender sample. No dependency, credential, shell-execution, or permission changes.
Agent Disclosure