From fd3513c5666396c450f5c4f18490391377e6d939 Mon Sep 17 00:00:00 2001 From: Jasper Huang Date: Tue, 26 Jul 2022 09:51:21 -0700 Subject: [PATCH 1/5] revert merge --- src/components/OfflineIndicator.js | 1 + src/components/ScreenWrapper.js | 60 +--- src/pages/AddPersonalBankAccountPage.js | 117 ++++--- .../EnablePayments/AdditionalDetailsStep.js | 250 ++++++------- .../EnablePayments/EnablePaymentsPage.js | 15 +- src/pages/GetAssistancePage.js | 59 ++-- src/pages/NewChatPage.js | 5 +- .../ReimbursementAccountPage.js | 55 +-- src/pages/RequestCallPage.js | 157 ++++----- src/pages/home/ReportScreen.js | 83 ++--- src/pages/home/report/ReportActionCompose.js | 2 +- src/pages/iou/IOUCurrencySelection.js | 29 +- src/pages/iou/IOUModal.js | 5 +- src/pages/settings/AddSecondaryLoginPage.js | 109 +++--- src/pages/settings/PasswordPage.js | 155 +++++---- .../settings/Payments/AddDebitCardPage.js | 159 ++++----- .../settings/Payments/AddPayPalMePage.js | 73 ++-- .../Payments/ChooseTransferAccountPage.js | 45 +-- .../Payments/PaymentsPage/BasePaymentsPage.js | 327 +++++++++--------- .../settings/Payments/TransferBalancePage.js | 187 +++++----- src/pages/settings/Profile/ProfilePage.js | 179 +++++----- .../settings/Security/CloseAccountPage.js | 145 ++++---- src/pages/workspace/WorkspaceInvitePage.js | 5 +- src/pages/workspace/WorkspaceNewRoomPage.js | 89 ++--- .../workspace/WorkspacePageWithSections.js | 57 +-- src/styles/styles.js | 8 - 26 files changed, 1213 insertions(+), 1163 deletions(-) diff --git a/src/components/OfflineIndicator.js b/src/components/OfflineIndicator.js index 94c0cb44f1fd..aafda94fdf0a 100644 --- a/src/components/OfflineIndicator.js +++ b/src/components/OfflineIndicator.js @@ -44,6 +44,7 @@ const OfflineIndicator = (props) => { return ( {}, }, modal: {}, - keyboardAvoidingViewBehavior: 'padding', }; class ScreenWrapper extends React.Component { @@ -120,36 +105,27 @@ class ScreenWrapper extends React.Component { paddingStyle.paddingTop = paddingTop; } - // We always need the safe area padding bottom if we're showing the offline indicator since it is bottom-docked. - if (this.props.includePaddingBottom || this.props.network.isOffline) { + if (this.props.includePaddingBottom) { paddingStyle.paddingBottom = paddingBottom; } return ( - - - - {// If props.children is a function, call it to provide the insets to the children. - _.isFunction(this.props.children) - ? this.props.children({ - insets, - didScreenTransitionEnd: this.state.didScreenTransitionEnd, - }) - : this.props.children - } - - {this.props.isSmallScreenWidth && this.props.network.isOffline && ( - - - - )} - + + {// If props.children is a function, call it to provide the insets to the children. + _.isFunction(this.props.children) + ? this.props.children({ + insets, + didScreenTransitionEnd: this.state.didScreenTransitionEnd, + }) + : this.props.children + } + ); }} @@ -163,11 +139,9 @@ ScreenWrapper.defaultProps = defaultProps; export default compose( withNavigation, - withWindowDimensions, withOnyx({ modal: { key: ONYXKEYS.MODAL, }, }), - withNetwork(), )(ScreenWrapper); diff --git a/src/pages/AddPersonalBankAccountPage.js b/src/pages/AddPersonalBankAccountPage.js index 6d6586fa1f0e..5a14ed6f7f45 100644 --- a/src/pages/AddPersonalBankAccountPage.js +++ b/src/pages/AddPersonalBankAccountPage.js @@ -13,6 +13,7 @@ import AddPlaidBankAccount from '../components/AddPlaidBankAccount'; import getPlaidOAuthReceivedRedirectURI from '../libs/getPlaidOAuthReceivedRedirectURI'; import compose from '../libs/compose'; import ONYXKEYS from '../ONYXKEYS'; +import KeyboardAvoidingView from '../components/KeyboardAvoidingView'; import Text from '../components/Text'; import styles from '../styles/styles'; import Button from '../components/Button'; @@ -124,65 +125,67 @@ class AddPersonalBankAccountPage extends React.Component { return ( - - {success ? ( - <> - - {success} - - -