From f31ba758208ee9ba432a210d8eec146f48f42654 Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Tue, 15 Nov 2022 10:43:19 -1000 Subject: [PATCH 1/5] Update CONTRIBUTING.md and PR Template to cover High Traffic and Offline situations --- .github/PULL_REQUEST_TEMPLATE.md | 12 +++++++++++- contributingGuides/CONTRIBUTING.md | 31 ++++++++++++++++-------------- 2 files changed, 28 insertions(+), 15 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a75f4ceeca2b..c9cf619f5dc3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -18,7 +18,7 @@ $ https://github.com/Expensify/App/issues/ Do NOT only link the issue number like this: $ # ---> -$ GH_LINK +$ GH_LINK PROPOSAL: GH_LINK_ISSUE(COMMENT) @@ -36,6 +36,11 @@ For example: - [ ] Verify that no errors appear in the JS console +### Offline tests + + ### QA Steps -$ GH_LINK +$ GH_LINK PROPOSAL: GH_LINK_ISSUE(COMMENT) From ab751e3043e2f5236307924b77fab9b864f95b1c Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Tue, 15 Nov 2022 11:03:21 -1000 Subject: [PATCH 5/5] Fix contributing.md Slack link --- contributingGuides/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributingGuides/CONTRIBUTING.md b/contributingGuides/CONTRIBUTING.md index 76b47f69e2dc..87a309fc567c 100644 --- a/contributingGuides/CONTRIBUTING.md +++ b/contributingGuides/CONTRIBUTING.md @@ -16,7 +16,7 @@ You can create as many accounts as needed in order to test your changes directly You can generate multiple test accounts by using a `+` postfix, for example if your email is test@test.com, you can create multiple New Expensify accounts connected to the same email address by using test+123@test.com, test+456@test.com, etc. ##### High Traffic Accounts -All internal engineers, contributors, and C+ members are **required** to test with a "high traffic" account against the staging or production web servers. Ask in `#expensify-open-source` if someone can turn your account into a High Traffic account. These accounts more closely mirror the accounts used in production by real people. Internal team members can follow [this Stack Overflow](https://stackoverflow.com/c/expensify/questions/14504) to upgrade an account. +All internal engineers, contributors, and C+ members are **required** to test with a "high traffic" account against the staging or production web servers. Ask in [#expensify-open-source](https://expensify.slack.com/archives/C01GTK53T8Q) if someone can turn your account into a High Traffic account. These accounts more closely mirror the accounts used in production by real people. Internal team members can follow [this Stack Overflow](https://stackoverflow.com/c/expensify/questions/14504) to upgrade an account. #### Working on beta features Some features are locked behind beta flags while development is ongoing. As a contributor you can work on these beta features locally by overriding the [`Permissions.canUseAllBetas` function](https://github.com/Expensify/App/blob/5e268df7f2989ed04bc64c0c86ed77faf134554d/src/libs/Permissions.js#L10-L12) to return `true`.