From da3d8a762d55b326f1a82c29e635841232e4b312 Mon Sep 17 00:00:00 2001 From: brunovjk Date: Mon, 29 Jan 2024 14:12:09 -0300 Subject: [PATCH 1/3] Rename .js files to .ts/.tsx for TypeScript migration --- src/pages/signin/AppleSignInDesktopPage/{index.js => index.ts} | 0 .../{index.website.js => index.website.tsx} | 0 .../signin/{DesktopRedirectPage.js => DesktopRedirectPage.tsx} | 0 src/pages/signin/DesktopSignInRedirectPage/{index.js => index.ts} | 0 .../{index.website.js => index.website.tsx} | 0 src/pages/signin/GoogleSignInDesktopPage/{index.js => index.ts} | 0 .../{index.website.js => index.website.tsx} | 0 7 files changed, 0 insertions(+), 0 deletions(-) rename src/pages/signin/AppleSignInDesktopPage/{index.js => index.ts} (100%) rename src/pages/signin/AppleSignInDesktopPage/{index.website.js => index.website.tsx} (100%) rename src/pages/signin/{DesktopRedirectPage.js => DesktopRedirectPage.tsx} (100%) rename src/pages/signin/DesktopSignInRedirectPage/{index.js => index.ts} (100%) rename src/pages/signin/DesktopSignInRedirectPage/{index.website.js => index.website.tsx} (100%) rename src/pages/signin/GoogleSignInDesktopPage/{index.js => index.ts} (100%) rename src/pages/signin/GoogleSignInDesktopPage/{index.website.js => index.website.tsx} (100%) diff --git a/src/pages/signin/AppleSignInDesktopPage/index.js b/src/pages/signin/AppleSignInDesktopPage/index.ts similarity index 100% rename from src/pages/signin/AppleSignInDesktopPage/index.js rename to src/pages/signin/AppleSignInDesktopPage/index.ts diff --git a/src/pages/signin/AppleSignInDesktopPage/index.website.js b/src/pages/signin/AppleSignInDesktopPage/index.website.tsx similarity index 100% rename from src/pages/signin/AppleSignInDesktopPage/index.website.js rename to src/pages/signin/AppleSignInDesktopPage/index.website.tsx diff --git a/src/pages/signin/DesktopRedirectPage.js b/src/pages/signin/DesktopRedirectPage.tsx similarity index 100% rename from src/pages/signin/DesktopRedirectPage.js rename to src/pages/signin/DesktopRedirectPage.tsx diff --git a/src/pages/signin/DesktopSignInRedirectPage/index.js b/src/pages/signin/DesktopSignInRedirectPage/index.ts similarity index 100% rename from src/pages/signin/DesktopSignInRedirectPage/index.js rename to src/pages/signin/DesktopSignInRedirectPage/index.ts diff --git a/src/pages/signin/DesktopSignInRedirectPage/index.website.js b/src/pages/signin/DesktopSignInRedirectPage/index.website.tsx similarity index 100% rename from src/pages/signin/DesktopSignInRedirectPage/index.website.js rename to src/pages/signin/DesktopSignInRedirectPage/index.website.tsx diff --git a/src/pages/signin/GoogleSignInDesktopPage/index.js b/src/pages/signin/GoogleSignInDesktopPage/index.ts similarity index 100% rename from src/pages/signin/GoogleSignInDesktopPage/index.js rename to src/pages/signin/GoogleSignInDesktopPage/index.ts diff --git a/src/pages/signin/GoogleSignInDesktopPage/index.website.js b/src/pages/signin/GoogleSignInDesktopPage/index.website.tsx similarity index 100% rename from src/pages/signin/GoogleSignInDesktopPage/index.website.js rename to src/pages/signin/GoogleSignInDesktopPage/index.website.tsx From 77980b1c1d6246b37d2c7006c67a6ce26ef3d332 Mon Sep 17 00:00:00 2001 From: brunovjk Date: Mon, 29 Jan 2024 14:16:31 -0300 Subject: [PATCH 2/3] Add // @ts-expect-error in pages using ThirdPartySignInPage --- src/pages/signin/AppleSignInDesktopPage/index.website.tsx | 7 ++++++- src/pages/signin/GoogleSignInDesktopPage/index.website.tsx | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/pages/signin/AppleSignInDesktopPage/index.website.tsx b/src/pages/signin/AppleSignInDesktopPage/index.website.tsx index 867dfddc443d..e23280a83132 100644 --- a/src/pages/signin/AppleSignInDesktopPage/index.website.tsx +++ b/src/pages/signin/AppleSignInDesktopPage/index.website.tsx @@ -3,7 +3,12 @@ import ThirdPartySignInPage from '@pages/signin/ThirdPartySignInPage'; import CONST from '@src/CONST'; function AppleSignInDesktopPage() { - return ; + return ( + + ); } export default AppleSignInDesktopPage; diff --git a/src/pages/signin/GoogleSignInDesktopPage/index.website.tsx b/src/pages/signin/GoogleSignInDesktopPage/index.website.tsx index b9451460dfb0..dda1a512e37d 100644 --- a/src/pages/signin/GoogleSignInDesktopPage/index.website.tsx +++ b/src/pages/signin/GoogleSignInDesktopPage/index.website.tsx @@ -3,7 +3,12 @@ import ThirdPartySignInPage from '@pages/signin/ThirdPartySignInPage'; import CONST from '@src/CONST'; function GoogleSignInDesktopPage() { - return ; + return ( + + ); } export default GoogleSignInDesktopPage; From 124eabb5b11bb8e3a5315616a75db79ac3645059 Mon Sep 17 00:00:00 2001 From: brunovjk Date: Mon, 29 Jan 2024 14:17:36 -0300 Subject: [PATCH 3/3] Remove JSDOC comments --- src/pages/signin/DesktopRedirectPage.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/pages/signin/DesktopRedirectPage.tsx b/src/pages/signin/DesktopRedirectPage.tsx index 1c2521be09e2..1c57df514f31 100644 --- a/src/pages/signin/DesktopRedirectPage.tsx +++ b/src/pages/signin/DesktopRedirectPage.tsx @@ -6,8 +6,6 @@ import * as App from '@userActions/App'; * Landing page for when a user enters third party login flow on desktop. * Allows user to open the link in browser if they accidentally canceled the auto-prompt. * Also allows them to continue to the web app if they want to use it there. - * - * @returns {React.Component} */ function DesktopRedirectPage() { return ;